Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree_skb (Was: Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT_BYPASS flag)
From: Jussi Kivilinna <hidden>
Date: 2008-08-07 12:37:14
From: Jussi Kivilinna <hidden>
Date: 2008-08-07 12:37:14
Quoting "Jarek Poplawski" [off-list ref]:
quoted
PS. I noticed something fishy in HTB; HTB always returns NET_XMIT_DROP if qdisc_enqueue doesn't return full NET_XMIT_SUCCESS, shouldn't it return return value from qdisc_enqueue. Same in HTB requeue. That can't be right, right?Yes, very good point, and quite hard to diagnose bug - happily solved already (but not fixed yet) by David Miller himself.
Ok, I assume that same case in sch_prio:requeue has been already spotted too.
PS: it seems your mailer wrapped some lines of above patch.
Doh, time to find alternative for horde. - Jussi