Thread (44 messages) 44 messages, 6 authors, 2008-08-19

Re: [PATCH 2/2 respin] net_sched: Add qdisc __NET_XMIT_BYPASS flag

From: Jarek Poplawski <hidden>
Date: 2008-08-05 06:42:15

On Mon, Aug 04, 2008 at 11:31:22PM -0700, David Miller wrote:
From: Jarek Poplawski <redacted>
Date: Tue, 5 Aug 2008 06:34:23 +0000
quoted
NAK! You're not allowed to remove such a great comment!

BTW, I hope you've checked this enough, becouse I've some doubts
here: this NET_XMIT_BYPASS looks wrong here but maybe it was meant
to be some NET_RX_ code, like NET_RX_CN_HIGH?
I think it was trying to handle the cases where the
input packet called dev_queue_xmit() and that return
value funnelled back into dst_input().

But that couldn't happen, and even if it could dev_queue_xmit()
always "fixed up" NET_XMIT_BYPASS so that callers never saw it.

Really, this code was totally useless as far as I can tell.
This looks reasonable, the only doubt is if it could get anywhere
this NET_RX_CN_HIGH (against original intention), because then
there would be some change. Anyway, the comment could stay...

Jarek P.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help