Re: [PATCH take 2] net_sched: Add qdisc __NET_XMIT_BYPASS flag
From: David Miller <davem@davemloft.net>
Date: 2008-08-05 21:22:55
From: David Miller <davem@davemloft.net>
Date: 2008-08-05 21:22:55
From: "Jussi Kivilinna" <redacted> Date: Tue, 05 Aug 2008 15:43:50 +0300
Quoting "Jarek Poplawski" [off-list ref]:quoted
On Mon, Aug 04, 2008 at 09:35:35PM +0300, Jussi Kivilinna wrote:quoted
Quoting "Jarek Poplawski" [off-list ref]: This seems to also make sure that when returning 'full' NET_XMIT_SUCCESS, skb pointer is safe(r?) to use now.I guess so... At least theoretically - I was mainly afraid of redirecting, which isn't fully implemented yet. On the other hand, outwards of qdiscs there is still no difference.How about making skb shared before passing into qdisc tree? That would make skb usage safe after qdisc enqueues.
That's two extra atomic operations on every transmitted packet, no thanks :-)