Re: [PATCH 0/2] Disable forwarding of LRO skbs
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-05-01 10:42:56
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-05-01 10:42:56
Ben Hutchings [off-list ref] wrote:
Large Receive Offload (LRO) destroys packet headers that should be preserved when forwarding. Currently it also triggers a BUG() or WARN() in skb_gso_segment(). We should disable it wherever forwarding is enabled, and discard LRO skbs with a warning if it is turned back on.
I don't think forwarding GSO packets is bad per se. However, doing LRO on forwarded traffic is broken because it breaks the end-to-end connection. So I agree that we should detect this but preferrably not based on the GSO flag as LRO isn't the only source of GSO traffic and the rest of them can be forwarded just fine. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt