Re: [PATCH 0/2] Disable forwarding of LRO skbs
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-05-01 10:20:05
David Miller [off-list ref] wrote:
From: Ben Hutchings <redacted> Date: Wed, 30 Apr 2008 22:48:46 +0100quoted
Large Receive Offload (LRO) destroys packet headers that should be preserved when forwarding. Currently it also triggers a BUG() or WARN() in skb_gso_segment(). We should disable it wherever forwarding is enabled, and discard LRO skbs with a warning if it is turned back on.Thanks for reposting your work, I'll take a closer look at these two patches later today.
This patch completely breaks forwarding of GSO packets in a virtualised environment where we explicitly want to forward them as is to reduce per-packet overhead. So if LRO is causing problems then I suggest we find a better way around that that does not penalise all forms of GSO. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt