Re: [PATCH 1/2] Disable forwarding of LRO skbs
From: David Miller <davem@davemloft.net>
Date: 2008-05-01 09:51:40
From: Ben Hutchings <redacted> Date: Wed, 30 Apr 2008 22:51:26 +0100
Add skb_warn_if_lro() to test whether an skb was received with LRO and warn if so. Change br_forward(), ip_forward() and ip6_forward() to call skb_warn_if_lro() and discard the skb if it returns true.
This skb_is_gso() test should be inline.
So, instead make this something like:
include/linux/skbuff.h:
extern bool __skb_warn_if_lro(const struct sk_buff *skb);
static inline bool skb_warn_if_lro(const struct sk_buff *skb)
{
if (unlikely(skb_is_gso(skb)))
return __skb_warn_if_lro(skb);
return false;
}
net/core/skbuff.c:
bool skb_warn_if_lro(const struct sk_buff *skb)
{
if (net_ratelimit())
pr_warning("%s: received packets cannot be forwarded"
" while LRO is enabled\n", skb->dev->name);
return true;
}
Can you make this correction and resubmit this patch?
The second one looks fine to me, you don't need to resubmit
that one.
Thanks!