Re: [PATCH 0/2] Disable forwarding of LRO skbs
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-05-01 10:39:06
On Thu, May 01, 2008 at 03:34:14AM -0700, David Miller wrote:
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Thu, 01 May 2008 18:19:54 +0800quoted
This patch completely breaks forwarding of GSO packets in a virtualised environment where we explicitly want to forward them as is to reduce per-packet overhead. So if LRO is causing problems then I suggest we find a better way around that that does not penalise all forms of GSO.I assume you mean forwarding via a bridge?
Not necessarily. For example we could be forwarding in a guest that's acting as a firewall appliance for other guests.
I think we'll need to add a device attribute for what you want.
I still don't understand why we can't forward LRO packets. It should be no different to forwarding GSO packets if it's properly constructed. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt