Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability

On 7/18/07, Patrick McHardy [off-list ref] wrote:

This could be done in the patch moving it .. anyways,

What?

Denis Cheng wrote:

quoted

+#ifdef CONFIG_PROC_FS
+static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos)

If you're interested in doing more work, it would be nice to
generalize the seq-file functions for unicast and multicast
address lists and add /proc/net/dev_unicast or something like
that.

Eh, there is already a dev_multicast file but lack of dev_unicast,
but is dev_unicast really useful?

OTOH we could also export this using rtnetlink. The main reason
why I didn't do that is that it can only be read, not changed,
but this is also true for statistics etc. Any opinions on this?

how to do that?

-- 
Denis Cheng
Linux Application Developer

"One of my most productive days was throwing away 1000 lines of code."
 - Ken Thompson.