Thread (18 messages) flat view 18 messages, 3 authors, 2007-07-20

Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c

From: David Miller <davem@davemloft.net>
Date: 2007-07-18 09:11:20
Also in: lkml

From: Denis Cheng <redacted>
Date: Wed, 18 Jul 2007 10:41:03 +0800
Because this function is only called by unregister_netdevice,
this moving could make this non-global function static,
and also remove its declaration in netdevice.h;

Any further, function __dev_addr_discard is also just called by
dev_mc_discard and dev_unicast_discard, keeping this two functions
both in one c file could make __dev_addr_discard also static
and remove its declaration in netdevice.h;

Futhermore, the sequential call to dev_unicast_discard and then
dev_mc_discard in unregister_netdevice have a similar mechanism that:
(netif_tx_lock_bh / __dev_addr_discard / netif_tx_unlock_bh),
they should merged into one to eliminate duplicates in acquiring and
releasing the dev->_xmit_lock, this would be done in my following patch.

Signed-off-by: Denis Cheng <redacted>
Patch applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help