Thread (18 messages) flat view 18 messages, 3 authors, 2007-07-20

Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c

From: David Miller <davem@davemloft.net>
Date: 2007-07-18 10:03:20
Also in: lkml

From: "rae l" <redacted>
Date: Wed, 18 Jul 2007 17:59:52 +0800
And then the dev_mcast.c is now only 256 lines long(versus dev.c 4052 lines),
just left a few multicast related functions definition and "dev_mcast"
procfs code,
I have an idea to merge all code dev_mcast.c into dev.c, that would:

- remove two functions (__dev_addr_delete, __dev_set_rx_mode) from netdevice.h,
  and then tag them static,
  those two are also defined in dev.c and only called from dev_mcast.c,

- reducing one file would benefit the compilation process.

All in one word, I don't think the single file dev_mcast.c is needed anymore.
Agreed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help