Re: [PATCH 04/10] net-sysfs.c changes.

On Sat, 21 Jul 2007 12:16:30 +0530
Krishna Kumar2 [off-list ref] wrote:

Stephen Hemminger [off-list ref] wrote on 07/20/2007
09:52:03 PM:

quoted

Patrick McHardy [off-list ref] wrote:

quoted

Krishna Kumar2 wrote:

quoted

Patrick McHardy [off-list ref] wrote on 07/20/2007 03:37:20 PM:

quoted

rtnetlink support seems more important than sysfs to me.

Thanks, I will add that as a patch. The reason to add to sysfs is

that

quoted

quoted

quoted

it is easier to change for a user (and similar to tx_queue_len).

But since batching is so similar to TSO, i really should be part of the
flags and controlled by ethtool like other offload flags.

So should I add all three interfaces (or which ones) :

      1. /sys (like for tx_queue_len)
      2. netlink
      3. ethtool.

Or only 2 & 3 are enough ?

Yes, please do #3 and maybe #2.
Sysfs api's are a long term ABI problem.