[ofa-general] Re: [PATCH 05/10] sch_generic.c changes.

Patrick McHardy [off-list ref] wrote on 07/20/2007 03:41:01 PM:

Krishna Kumar wrote:

quoted

diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c

--- org/net/sched/sch_generic.c   2007-07-20 07:49:28.000000000 +0530
+++ new/net/sched/sch_generic.c   2007-07-20 08:30:22.000000000 +0530

@@ -9,6 +9,11 @@
  * Authors:   Alexey Kuznetsov, <kuznet@ms2.inr.ac.ru>
  *              Jamal Hadi Salim, <hadi@cyberus.ca> 990601
  *              - Ingress support
+ *
+ * New functionality:
+ *      Krishna Kumar, <krkumar2@in.ibm.com>, July 2007
+ *      - Support for sending multiple skbs to devices that support
+ *        new api - dev->hard_start_xmit_batch()

No new changelogs in source code please, git keeps track of that.

Ah, didn't know this, thanks for letting me know.

quoted

-static inline int qdisc_restart(struct net_device *dev)
+static inline int qdisc_restart(struct net_device *dev,
+            struct sk_buff_head *blist)
 {
    struct Qdisc *q = dev->qdisc;
    struct sk_buff *skb;
-   unsigned lockless;
+   unsigned getlock;      /* whether we need to get lock or not */

Unrelated rename, please get rid of this to reduce the noise.

OK, I guess I should have sent that change earlier :) The reason to change
the name is to avoid (double-negative) checks like :

      if (!lockless)
to
      if (getlock).

I will remove these changes.

thanks,

- KK