This is boring, I reversed everything to not change any semantics and
you still complain.

* jamal [off-list ref] 2006-06-30 17:35

On Fri, 2006-30-06 at 23:20 +0200, Thomas Graf wrote:

quoted

* jamal [off-list ref] 2006-06-30 17:09

quoted

the ref inside the else below after changing input_dev 

A non-existant iif is already equivalent to !iif since it jumps
into the same branch. 

I thought 0 was a valid iif as Ben G was pointing - if it is not, you
are right. 

No, 1 ist the first valid ifindex, see dev_new_index().

quoted

Grabing a reference is completely pointless,
the netdevice represented by skb->iif is at this point until the
packet gets queued covered by a reference taken in netif_rx().

You have to consider that this could happen at both ingress and egress.

Just think for a second, do you expect the device the packet will
be leaving at to disappear?