Thread (87 messages) 87 messages, 6 authors, 2006-07-09

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

From: Thomas Graf <tgraf@suug.ch>
Date: 2006-06-30 16:32:08

* jamal [off-list ref] 2006-06-30 10:35
On Fri, 2006-30-06 at 16:15 +0200, Thomas Graf wrote:
quoted
eth0::tcf_mirred()     skb->dev = ifb0, input_dev = eth0
ifb0::tcf_mirred()     skb->dev = ifb1, input_dev = ifb0
ifb1::ifb_xmit()       skb->dev = ifb0, input_dev = ifb1, set ncls bit
ifb0::ifb_xmit()       skb->dev = ifb1, input_dev = ifb0
ifb1::ifb_xmit()       skb->dev = ifb0, input_dev = ifb1
...

Oh dear... and we don't even have a ttl to catch this.
Did you actually try to run this before you reached this conclusion?
I did, fortunately some other bug prevents this from happening,
packets are simply dropped somewhere.
With all due respect, the architecture works. I have invested many many
hours testing and verifying. There may be coding bugs - and those need
fixing. Kill the bugs.
Right, just run this

tc filter add dev eth0 parent 1: protocol ip prio 10
              u32 match ip tos 0 0 flowid 1:1
	      action mirred egress redirect dev ifb1
tc filter add dev ifb1 parent 1: protocol ip prio 10
              u32 match ip tos 0 0 flowid 1:1
	      action mirred egress redirect dev ifb0


Anyways, I give up. Last time I've been running after you trying
to fix the many bugs you leave behind. Ever noticed that whenever
you add some new code it's someone else following up with tons of
small bugfix patches having a hard time trying to figure out the
actual intent. I'll just duplicate the code for my purpose, so
much easier.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help