Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device
From: Thomas Graf <tgraf@suug.ch>
Date: 2006-06-30 17:34:17
From: Thomas Graf <tgraf@suug.ch>
Date: 2006-06-30 17:34:17
* jamal [off-list ref] 2006-06-30 13:19
On Fri, 2006-30-06 at 18:32 +0200, Thomas Graf wrote:quoted
* jamal [off-list ref] 2006-06-30 10:35quoted
quoted
Did you actually try to run this before you reached this conclusion?I did, fortunately some other bug prevents this from happening, packets are simply dropped somewhere.It is not a bug, Thomas! I am getting a little frustrated now. The packets will be dropped because we set the at field to zero which is invalid. That is done on purpose. It is only meaningful for ifb. The challenge is much bigger than it appears. You could end up deadlocking on the tx lock. So this was the choice i had to make.
Please explain, tc_verd is reset in the tasklet after dequeueing and set again in dev_queue_xmit(). ifb_xmit will always see a valid tc_verd at egress.