Thread (114 messages) 114 messages, 9 authors, 2005-04-22

[23/*] [IPV4] Kill remaining unnecessary uses of dst_pmtu

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-03-18 09:19:18

Hi Dave:

Once again here is a couple of trivial dst_pmtu/dst_mtu replacements.
In both locations, we can only have simple dst entries which means
that dst == dst->path.

BTW, this is the rule that we should apply in future for uses of
dst_mtu/dst_pmtu (or other metrics on dst).  If the only dst's that
can appear are simple dst's (dst == dst->path), then we should use
dst_mtu or dst_metric.  If dst != dst->path, then whoever is writing
the code will need to think about which of dst or dst->path is the
right one.

In most instances dst will be the one.  However, as we have seen in
ip_append_data, dst->path may be needed rarely.  In particular, if
we're doing fragmentation immediately after IPsec, then you may need
it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
 
Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help