[14/*] [IPV6] Reload skb->dst after xfrm6_route_forward

[1/4] [IPSEC] Merge xfrm[46]_bundle/stale_bundle · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-14
[2/4] [IPSEC] Add xfrm_state_mtu · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-14
[3/4] [IPSEC] Add route element to xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-14
[4/4] [IPSEC] Store MTU at each xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-14
Re: [4/4] [IPSEC] Store MTU at each xfrm_dst · James Morris <hidden> · 2005-02-15
Re: [4/4] [IPSEC] Store MTU at each xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-15
[5/*] [IPSEC] Use dst_mtu in xfrm[46]_output · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-16
[6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-16
[7/*] [IPSEC] Get metrics for xfrm_dst from top dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-16
Re: [7/*] [IPSEC] Get metrics for xfrm_dst from top dst · "David S. Miller" <davem@davemloft.net> · 2005-03-07
Re: [7/*] [IPSEC] Get metrics for xfrm_dst from top dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
Re: [6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst · "David S. Miller" <davem@davemloft.net> · 2005-03-07
Re: [6/*] [IPSEC] Fix xfrm[46]_update_pmtu to update top dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
Re: [5/*] [IPSEC] Use dst_mtu in xfrm[46]_output · "David S. Miller" <davem@davemloft.net> · 2005-03-07
[10/*] [TCP] Get rid of dst_ptmu/ext2_header_len · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
Re: [10/*] [TCP] Get rid of dst_ptmu/ext2_header_len · "David S. Miller" <davem@davemloft.net> · 2005-03-07
Re: [4/4] [IPSEC] Store MTU at each xfrm_dst · "David S. Miller" <davem@davemloft.net> · 2005-03-07
[9/*] [IPSEC] Check dst validity harder in xfrm_bundle_ok · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
Re: [9/*] [IPSEC] Check dst validity harder in xfrm_bundle_ok · "David S. Miller" <davem@davemloft.net> · 2005-03-07
[11/*] [NET] Move dst_release out of dst->ops->check · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-08
Re: [11/*] [NET] Move dst_release out of dst->ops->check · YOSHIFUJI Hideaki / 吉藤英明 <hidden> · 2005-03-08
Re: [11/*] [NET] Move dst_release out of dst->ops->check · "David S. Miller" <davem@davemloft.net> · 2005-03-11
[12/*] [IPSEC] Handle local_df in IPv4 · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-14
[13/*] [IPV4] Fix room calculation in icmp_send · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-14
[14/*] [IPV6] Reload skb->dst after xfrm6_route_forward · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-14
Re: [14/*] [IPV6] Reload skb->dst after xfrm6_route_forward · "David S. Miller" <davem@davemloft.net> · 2005-03-15
[15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
[16/*] [INET] Take IPsec overhead into account in tunnels · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
[17/*] [NET] Replace dst_pmtu with dst_mtu · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
Re: [17/*] [NET] Replace dst_pmtu with dst_mtu · "David S. Miller" <davem@davemloft.net> · 2005-03-15
Re: [17/*] [NET] Replace dst_pmtu with dst_mtu · Patrick McHardy <hidden> · 2005-03-15
Replace send_unreach with icmp_send · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
Re: Replace send_unreach with icmp_send · Patrick McHardy <hidden> · 2005-03-15
[IPV4] Make ipt_REJECT use icmp_send again · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-16
Re: [IPV4] Make ipt_REJECT use icmp_send again · Patrick McHardy <hidden> · 2005-03-16
Re: [IPV4] Make ipt_REJECT use icmp_send again · "David S. Miller" <davem@davemloft.net> · 2005-03-16
[IPV4] Send TCP reset through dst_output in ipt_REJECT · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-17
Re: [IPV4] Send TCP reset through dst_output in ipt_REJECT · "David S. Miller" <davem@davemloft.net> · 2005-03-17
Re: [17/*] [NET] Replace dst_pmtu with dst_mtu · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
Re: [16/*] [INET] Take IPsec overhead into account in tunnels · Lennert Buytenhek <hidden> · 2005-03-15
Re: [16/*] [INET] Take IPsec overhead into account in tunnels · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-15
Re: [16/*] [INET] Take IPsec overhead into account in tunnels · "David S. Miller" <davem@davemloft.net> · 2005-03-15
[21/*] [IPv4] Fix MTU check in ipmr_queue_xmit · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[23/*] [IPV4] Kill remaining unnecessary uses of dst_pmtu · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[24/*] [IPSEC] Get ttl from child instead of path · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[25/*] [NET] Kill unnecessary uses of dst_path_metric · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[26/*] [NET] Kill dst_pmtu/dst_path_metric · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
[27/*] [NET] Make dst_allfrag use dst instead of dst->path · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-18
Re: [27/*] [NET] Make dst_allfrag use dst instead of dst->path · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [26/*] [NET] Kill dst_pmtu/dst_path_metric · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [25/*] [NET] Kill unnecessary uses of dst_path_metric · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [24/*] [IPSEC] Get ttl from child instead of path · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [23/*] [IPV4] Kill remaining unnecessary uses of dst_pmtu · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Patrick McHardy <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Ludo Stellingwerff <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Lennert Buytenhek <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Patrick McHardy <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Ludo Stellingwerff <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Patrick McHardy <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · jamal <hidden> · 2005-03-20
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Patrick McHardy <hidden> · 2005-03-20
Extending xfrm_selector (Was: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS) · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-30
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · "David S. Miller" <davem@davemloft.net> · 2005-03-23
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Patrick McHardy <hidden> · 2005-03-23
Netfilter+IPsec · Patrick McHardy <hidden> · 2005-03-24
Re: Netfilter+IPsec · "David S. Miller" <davem@davemloft.net> · 2005-03-24
Re: Netfilter+IPsec · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-25
Re: Netfilter+IPsec · Patrick McHardy <hidden> · 2005-03-25
Re: [22/*] [NETFILTER] Use correct IPsec MTU in TCPMSS · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-23
Re: [21/*] [IPv4] Fix MTU check in ipmr_queue_xmit · "David S. Miller" <davem@davemloft.net> · 2005-03-18
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · "David S. Miller" <davem@davemloft.net> · 2005-03-15
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-16
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · "David S. Miller" <davem@davemloft.net> · 2005-03-16
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Mika Penttilä <hidden> · 2005-03-21
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-21
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Mika Penttilä <hidden> · 2005-03-21
Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-21
Re: [13/*] [IPV4] Fix room calculation in icmp_send · "David S. Miller" <davem@davemloft.net> · 2005-03-15
Re: [12/*] [IPSEC] Handle local_df in IPv4 · "David S. Miller" <davem@davemloft.net> · 2005-03-15
Re: [12/*] [IPSEC] Handle local_df in IPv4 · YOSHIFUJI Hideaki / 吉藤英明 <hidden> · 2005-03-15
Re: [12/*] [IPSEC] Handle local_df in IPv4 · YOSHIFUJI Hideaki / 吉藤英明 <hidden> · 2005-03-15
Re: [4/4] [IPSEC] Store MTU at each xfrm_dst · Patrick McHardy <hidden> · 2005-03-28
[IPSEC] Move xfrm_flush_bundles into xfrm_state GC · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-28
Re: [IPSEC] Move xfrm_flush_bundles into xfrm_state GC · Patrick McHardy <hidden> · 2005-03-31
Re: [IPSEC] Move xfrm_flush_bundles into xfrm_state GC · "David S. Miller" <davem@davemloft.net> · 2005-04-01
Checking SPI in xfrm_state_find · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-28
Re: Checking SPI in xfrm_state_find · Patrick McHardy <hidden> · 2005-03-31
Re: Checking SPI in xfrm_state_find · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-31
Re: Checking SPI in xfrm_state_find · "David S. Miller" <davem@davemloft.net> · 2005-04-01
[IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Herbert Xu <herbert@gondor.apana.org.au> · 2005-04-02
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · "David S. Miller" <davem@davemloft.net> · 2005-04-02
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Herbert Xu <herbert@gondor.apana.org.au> · 2005-04-02
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Patrick McHardy <hidden> · 2005-04-03
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Herbert Xu <herbert@gondor.apana.org.au> · 2005-04-05
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Patrick McHardy <hidden> · 2005-04-05
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Herbert Xu <herbert@gondor.apana.org.au> · 2005-04-06
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · "David S. Miller" <davem@davemloft.net> · 2005-04-21
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Herbert Xu <herbert@gondor.apana.org.au> · 2005-04-21
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · Patrick McHardy <hidden> · 2005-04-21
Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel · "David S. Miller" <davem@davemloft.net> · 2005-04-22
Re: Checking SPI in xfrm_state_find · Patrick McHardy <hidden> · 2005-04-03
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Mika Penttilä <hidden> · 2005-02-15
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-02-15
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Mika Penttilä <hidden> · 2005-02-15
Re: [3/4] [IPSEC] Add route element to xfrm_dst · "David S. Miller" <davem@davemloft.net> · 2005-03-07
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
[IPSEC] Kill redundan dst_release check in xfrm_dst_destroy · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-07
Re: [IPSEC] Kill redundan dst_release check in xfrm_dst_destroy · "David S. Miller" <davem@davemloft.net> · 2005-03-07
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Patrick McHardy <hidden> · 2005-03-14
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Herbert Xu <herbert@gondor.apana.org.au> · 2005-03-14
Re: [3/4] [IPSEC] Add route element to xfrm_dst · Patrick McHardy <hidden> · 2005-03-15
Re: [2/4] [IPSEC] Add xfrm_state_mtu · "David S. Miller" <davem@davemloft.net> · 2005-03-07

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-03-14 11:10:02

Hi Dave:

While replacing dst_pmtu in ip6_output I found this little gem.  In
ip6_forward we're not reloading the dst pointer after calling
xfrm6_route_forward.  So all subsequent dereferences of dst will
refer to its pre-IPsec value.

The solution is of course to refresh its value.
 
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachments

xfrm-14 [text/plain] 381 bytes · preview

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help