Re: [PATCH] xarray: port tests to kunit

From
Tamir Duberstein <hidden>
Date
2025-01-29 23:18:18
Also in
linux-m68k, linux-mm, lkml, llvm
Reply to
Matthew Wilcox, 2025-01-29
On Wed, Jan 29, 2025 at 6:11 PM Matthew Wilcox [off-list ref] wrote:
On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote:
quoted
The whole point of tools is to liberate stupid humans' brains like
mine from mundane tasks like working out who to email. The tool wasn't
wrong; it did exactly what you told it to do in your MAINTAINERS
entry.
Tools do get things wrong.  So do humans.  When you take your hands off
the steering wheel and the car crashes, it's still your fault.
Which one of us is driving in this analogy?
quoted
quoted
quoted
For what it's worth the kunit invocation, while obscure, is
self-documenting. There's usage information that's reasonably
understandable embedded in the tool itself. I looked for the userspace
testing initially but failed to find
tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm
meant to compile this.
kunit is useless.  The test_xarray.c module is useless.  If you break
xarray, the kernel won't boot far enough to load any modules.  You
haven't thought about this AT ALL.
I don't understand what you're saying here.
Then I don't want to see any more patches from you until you do.
Yes, I see now. But it's not quite true; the patch was itself
motivated by the difficult output of the tests, so I did run this with
kunit in a state that produced a failure. Your point is taken.
Thread (22 messages) 22 messages, 7 authors, last reply 2025-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help