Re: [PATCH] xarray: port tests to kunit

From
Matthew Wilcox <willy@infradead.org>
Date
2025-01-29 23:02:55
Also in
linux-m68k, linux-mm, lkml, llvm
Reply to
Tamir Duberstein, 2025-01-29
On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote:
quoted
 $ ./scripts/get_maintainer.pl --git lib/xarray.c
Matthew Wilcox [off-list ref] (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_lines:4/23=17%)
Andrew Morton [off-list ref] (supporter:LIBRARY CODE,commit_signer:3/3=100%)
I'm not sure what you're asking. I used `b4 prep --auto-to-cc`. It
doesn't know that test_xarray.c and xarray.c have the same maintainer.
You need to use your brain.  You can't just say "I used the tool".
Tools are just tools.  Sometimes they're wrong.  My email address is
listed as the Author: of test_xarray.c.  You should have noticed that.
For what it's worth the kunit invocation, while obscure, is
self-documenting. There's usage information that's reasonably
understandable embedded in the tool itself. I looked for the userspace
testing initially but failed to find
tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm
meant to compile this.
kunit is useless.  The test_xarray.c module is useless.  If you break
xarray, the kernel won't boot far enough to load any modules.  You
haven't thought about this AT ALL.

cd tools/testing/radix-tree
make

Then you can run the tests, whichever ones make sense for you to run.
Thread (22 messages) 22 messages, 7 authors, last reply 2025-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help