Re: [PATCH] xarray: port tests to kunit

From
Liam R. Howlett <hidden>
Date
2025-01-29 21:27:21
Also in
linux-m68k, linux-mm, lkml, llvm
Reply to
Sidhartha Kumar, 2025-01-29
* Sidhartha Kumar [off-list ref] [250129 16:02]:
+ Liam, Matthew
+ linux-mm

Thank you Sid.
Hello,

I believe this patch needs to be reverted for now as it breaks the
user-space build of /tools/testing/radix-tree with:

In file included from xarray.c:11:
../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such file
or directory
     9 | #include <kunit/test.h>
       |          ^~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: xarray.o] Error 1
make: *** Waiting for unfinished jobs....

this then prevents the maple tree test suite from building.
How are grammar corrections going to the right person (but not the
mailing list) while an entire conversion to kunit is not [1]?

Does the patch really need to drop the module testing too?

What exactly is the point of converting one testing system to another
besides disruption of actual work?  Who asked for this?  What is the
point?

Is anyone doing work on the xarray running the kunit tests?

This should be reverted as it should never have been merged.

Regards,
Liam

[1]. https://lore.kernel.org/all/20241009193602.41797-2-tamird@gmail.com/ (local)
Thread (22 messages) 22 messages, 7 authors, last reply 2025-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help