On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett [off-list ref] wrote:

* Sidhartha Kumar [off-list ref] [250129 16:02]:

quoted

+ Liam, Matthew

+ linux-mm

Thank you Sid.

quoted

Hello,

I believe this patch needs to be reverted for now as it breaks the
user-space build of /tools/testing/radix-tree with:

In file included from xarray.c:11:
../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such file
or directory
     9 | #include <kunit/test.h>
       |          ^~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: xarray.o] Error 1
make: *** Waiting for unfinished jobs....

this then prevents the maple tree test suite from building.

How are grammar corrections going to the right person (but not the
mailing list) while an entire conversion to kunit is not [1]?

Very simple: the tests are not properly included in MAINTAINERS. I
sent https://lore.kernel.org/all/20250129-xarray-test-maintainer-v1-1-482e31f30f47@gmail.com/ (local)
a few minutes ago for this reason.

Does the patch really need to drop the module testing too?

What exactly is the point of converting one testing system to another
besides disruption of actual work?  Who asked for this?  What is the
point?

All this is described in the commit message.

Is anyone doing work on the xarray running the kunit tests?

I was doing work on xarray and I was running the kunit tests.

This should be reverted as it should never have been merged.

Regards,
Liam

[1]. https://lore.kernel.org/all/20241009193602.41797-2-tamird@gmail.com/ (local)