Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-11-10 18:41:54
Also in:
linux-pci
On Wed, Nov 10, 2021 at 07:07:24PM +0100, Christian Zigotzky wrote:
On 09 November 2021 at 03:45 pm, Christian Zigotzky wrote:quoted
Hello, The Nemo board [1] doesn't recognize any ATA disks with the pci-v5.16updates [2].quoted
Error messages: ata4.00: gc timeout cmd 0xec ata4.00: failed to IDENTIFY (I/O error, error_mask=0x4) ata1.00: gc timeout cmd 0xec ata1.00: failed to IDENTIFY (I/O error, error_mask=0x4) ata3.00: gc timeout cmd 0xec ata3.00: failed to IDENTIFY (I/O error, error_mask=0x4) I was able to revert the new pci-v5.16 updates [2]. After a newcompiling, the kernel recognize all ATA disks correctly.quoted
Could you please check the pci-v5.16 updates [2]? Please find attached the kernel config. Thanks, Christian [1] https://en.wikipedia.org/wiki/AmigaOne_X1000 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c5c62ddf88c34bc83b66e4ac9beb2bb0e1887d4Hi All, Many thanks for your nice responses. I bisected today [1]. 0412841812265734c306ba5ef8088bcb64d5d3bd (of/irq: Allow matching of an interrupt-map local to an interrupt controller) [2] is the first bad commit. I was able to revert the first bad commit [1]. After a new compiling, the kernel detects all ATA disks without any problems. I created a patch for an easy reverting the bad commit [1]. With this patch we can do further our kernel tests. Could you please check the first bad commit [2]? Thanks, Christian [1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54398#p54398 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0412841812265734c306ba5ef8088bcb64d5d3bd [+ Marc Zyngier, Alyssa Rosenzweig, Lorenzo Pieralisi, and Rob Herring because of the first bad commit]
Thank you very much for the bisection and for also testing the revert!
It's easy enough to revert 041284181226 ("of/irq: Allow matching of an
interrupt-map local to an interrupt controller"), and it seems like
that's what we need to do. I have it tentatively queued up.
That commit was part of the new support for the Apple M1 PCIe
interface, and I don't know what effect a revert will have on that
support. Marc, Alyssa?
Bjorn