Re: [PATCH 12/15] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2020-03-18 23:36:26
Also in:
lkml
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2020-03-18 23:36:26
Also in:
lkml
Segher Boessenkool [off-list ref] writes:
On Wed, Mar 18, 2020 at 12:44:52PM +0100, Christophe Leroy wrote:quoted
Le 18/03/2020 à 12:35, Michael Ellerman a écrit :quoted
Christophe Leroy [off-list ref] writes:quoted
Le 09/03/2020 à 09:58, Ravi Bangoria a écrit :quoted
Currently we assume that we have only one watchpoint supported by hw. Get rid of that assumption and use dynamic loop instead. This should make supporting more watchpoints very easy.I think using 'we' is to be avoided in commit message.Hmm, is it? I use 'we' all the time. Which doesn't mean it's correct, but I think it reads OK. cheersFrom https://www.kernel.org/doc/html/latest/process/submitting-patches.html : Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour.That is what is there already? "Get rid of ...". You cannot describe the current situation with an imperative.
Yeah, I think the use of 'we' and the imperative mood are separate things. ie. this uses 'we' to describe the current behaviour and then the imperative mood to describe the change that's being made: Currently we assume xyzzy always does bar, which is incorrect. Change it to do frotz. cheers