Thread (54 messages) 54 messages, 4 authors, 2020-03-26

Re: [PATCH 12/15] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint

From: Christophe Leroy <hidden>
Date: 2020-03-18 11:44:59
Also in: lkml


Le 18/03/2020 à 12:35, Michael Ellerman a écrit :
Christophe Leroy [off-list ref] writes:
quoted
Le 09/03/2020 à 09:58, Ravi Bangoria a écrit :
quoted
Currently we assume that we have only one watchpoint supported by hw.
Get rid of that assumption and use dynamic loop instead. This should
make supporting more watchpoints very easy.
I think using 'we' is to be avoided in commit message.
Hmm, is it?

I use 'we' all the time. Which doesn't mean it's correct, but I think it
reads OK.

cheers
 From 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html :

Describe your changes in imperative mood, e.g. “make xyzzy do frotz” 
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to 
do frotz”, as if you are giving orders to the codebase to change its 
behaviour.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help