Thread (54 messages) 54 messages, 4 authors, 2020-03-26

Re: [PATCH 11/15] powerpc/watchpoint: Introduce is_ptrace_bp() function

From: Christophe Leroy <hidden>
Date: 2020-03-17 10:49:25
Also in: lkml


Le 09/03/2020 à 09:58, Ravi Bangoria a écrit :
quoted hunk ↗ jump to hunk
Introduce is_ptrace_bp() function and move the check inside the
function. We will utilize it more in later set of patches.

Signed-off-by: Ravi Bangoria <redacted>
---
  arch/powerpc/kernel/hw_breakpoint.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
index b27aca623267..0e35ff372d8e 100644
--- a/arch/powerpc/kernel/hw_breakpoint.c
+++ b/arch/powerpc/kernel/hw_breakpoint.c
@@ -90,6 +90,11 @@ void arch_uninstall_hw_breakpoint(struct perf_event *bp)
  	hw_breakpoint_disable();
  }
  
+static bool is_ptrace_bp(struct perf_event *bp)
+{
+	return (bp->overflow_handler == ptrace_triggered);
You don't need parenthesis here.
quoted hunk ↗ jump to hunk
+}
+
  /*
   * Perform cleanup of arch-specific counters during unregistration
   * of the perf-event
@@ -324,7 +329,7 @@ int hw_breakpoint_handler(struct die_args *args)
  	 * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal
  	 * generated in do_dabr().
  	 */
-	if (bp->overflow_handler == ptrace_triggered) {
+	if (is_ptrace_bp(bp)) {
  		perf_bp_event(bp, regs);
  		rc = NOTIFY_DONE;
  		goto out;
Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help