On 3/18/20 2:26 PM, Christophe Leroy wrote:

Le 18/03/2020 à 09:36, Ravi Bangoria a écrit :

quoted

On 3/17/20 4:07 PM, Christophe Leroy wrote:

quoted

Le 09/03/2020 à 09:58, Ravi Bangoria a écrit :

quoted

So far powerpc hw supported only one watchpoint. But Future Power
architecture is introducing 2nd DAWR. Convert thread_struct->hw_brk
into an array.

Looks like you are doing a lot more than that in this patch.

Should this patch be splitted in two parts ?

So far thread_struct->hw_brk was a normal variable so accessing it was simple.
Once it gets converted into an array, loop needs to be used to access it. So
all misc changes are basically converting simple access into loops.

I don't see how this can be splitted.

You could first change all thread_struct->hw_brk to thread_struct->hw_brk[0] or thread_struct->hw_brk[i] when you know that i can only be 0 for now. Then add the loops and new functions in a second patch.

Ok. I've already tried that :) But it looked unnecessary split to
me because _all_ hw_brk => hw_brk[0] changes will again need to be
changed to use loop in 2nd patch. So I thought it's better to do
both changes in one patch.

Thanks,
Ravi