Re: [PATCH 00/50] Add log level to show_stack()
From: Petr Mladek <pmladek@suse.com>
Date: 2019-11-12 09:59:32
Also in:
linux-alpha, linux-riscv, linux-um
On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote:
On (19/11/12 13:44), Sergey Senozhatsky wrote: [..]quoted
quoted
But yes, this per-code-section loglevel is problematic. The feedback against the patchset shows that people want it also the other way. I mean to keep pr_debug() as pr_debug().Hmm. Right.quoted
A solution might be to use the per-code-section loglevel only instead of some special loglevel.So maybe we can "overwrite" only KERN_DEFAULT loglevels?LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? So we can downgrade some messages (log_store() only) or promote some messages. DEBUG perhaps should stay debug.quoted
We certainly should not mess with SCHED or with anything in between EMERG and ERR.[EMERG, WARN]
This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr