Re: [PATCH 00/50] Add log level to show_stack()
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2019-11-07 00:52:07
Also in:
linux-alpha, linux-riscv, linux-um
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2019-11-07 00:52:07
Also in:
linux-alpha, linux-riscv, linux-um
On Wed, Nov 06, 2019 at 09:34:40PM +0100, Peter Zijlstra wrote:
I suppose I'm surprised there are backtraces that are not important. Either badness happened and it needs printing, or the user asked for it and it needs printing.
Or utterly meaningless.
Perhaps we should be removing backtraces if they're not important instead of allowing to print them as lower loglevels?
Definitely! WARN_ON() is well overused - and as is typical, used without much thought. Bound to happen after Linus got shirty about BUG_ON() being over used. Everyone just grabbed the next nearest thing to assert(). As a kind of example, I've recently come across one WARN_ON() in a driver subsystem (that shall remain nameless at the moment) which very likely has multiple different devices on a platform. The WARN_ON() triggers as a result of a problem with the hardware, but because it's a WARN_ON(), you've no idea which device has a problem. The backtrace is mostly meaningless. So you know that a problem has occurred, but the kernel prints *useless* backtrace to let you know, and totally omits the *useful* information. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up