Thread (80 messages) 80 messages, 6 authors, 2019-11-20

Re: [PATCH v4 45/47] net/wan/fsl_ucc_hdlc: reject muram offsets above 64K

From: Timur Tabi <timur@kernel.org>
Date: 2019-11-15 14:33:57
Also in: linux-arm-kernel, lkml, netdev

On 11/15/19 1:44 AM, Rasmus Villemoes wrote:
I can change it, sure, but it's a matter of taste. To me the above asks
"does the value change when it is truncated to a u16" which makes
perfect sense when the value is next used with iowrite16be(). Using a
comparison to U16_MAX takes more brain cycles for me, because I have to
think whether it should be > or >=, and are there some
signedness/integer promotion business interfering with that test.
Ok.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help