Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

On 14/11/2019 14.57, Timur Tabi wrote:

On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
[off-list ref] wrote:

quoted

-       if (*iprop)
-               qe_port->port.uartclk = *iprop;
+       if (val)
+               qe_port->port.uartclk = val;
        else {
                /*
                 * Older versions of U-Boot do not initialize the brg-frequency
                 * property, so in this case we assume the BRG frequency is
                 * half the QE bus frequency.
                 */

This bug in older U-Boots is definitely PowerPC-specific, so could you
change this so that it reports an error on ARM if brg-frequency is
zero, and displays a warning on PowerPC?

That would be a separate patch, this patch is only concerned with
eliminating the implicit assumption of the host being big-endian. And
there's already been some pushback to adding arch-specific ifdefs (which
I agree with, but as I responded there see as the lesser evil), so
unless there's a very good reason to add that complexity, I'd rather not.

Rasmus