Re: [PATCH v2 23/23] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

Hi Rasmus,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc5 next-20191028]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rasmus-Villemoes/QUICC-Engine-support-on-ARM/20191028-202537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d6d5df1db6e9d7f8f76d2911707f7d5877251b02
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_get_low_irq':

quoted

drivers/soc/fsl/qe/qe_ic.c:384:10: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?

      return NO_IRQ;
             ^~~~~~
             NR_IRQS
   drivers/soc/fsl/qe/qe_ic.c:384:10: note: each undeclared identifier is reported only once for each function it appears in
   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_get_high_irq':
   drivers/soc/fsl/qe/qe_ic.c:400:10: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?
      return NO_IRQ;
             ^~~~~~
             NR_IRQS
   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_cascade_low':
   drivers/soc/fsl/qe/qe_ic.c:411:21: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?
     if (cascade_irq != NO_IRQ)
                        ^~~~~~
                        NR_IRQS
   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_cascade_high':
   drivers/soc/fsl/qe/qe_ic.c:424:21: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?
     if (cascade_irq != NO_IRQ)
                        ^~~~~~
                        NR_IRQS
   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_cascade_muxed_mpic':
   drivers/soc/fsl/qe/qe_ic.c:438:21: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?
     if (cascade_irq == NO_IRQ)
                        ^~~~~~
                        NR_IRQS
   drivers/soc/fsl/qe/qe_ic.c: In function 'qe_ic_init':
   drivers/soc/fsl/qe/qe_ic.c:477:25: error: 'NO_IRQ' undeclared (first use in this function); did you mean 'NR_IRQS'?
     if (qe_ic->virq_low == NO_IRQ) {
                            ^~~~~~
                            NR_IRQS

vim +384 drivers/soc/fsl/qe/qe_ic.c

9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  372  
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  373  /* Return an interrupt vector or NO_IRQ if no interrupt is pending. */
35a84c2f56e0f7 arch/powerpc/sysdev/qe_lib/qe_ic.c Olaf Hering 2006-10-07  374  unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic)
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  375  {
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  376  	int irq;
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  377  
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  378  	BUG_ON(qe_ic == NULL);
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  379  
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  380  	/* get the interrupt source vector. */
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  381  	irq = qe_ic_read(qe_ic->regs, QEIC_CIVEC) >> 26;
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  382  
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  383  	if (irq == 0)
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03 @384  		return NO_IRQ;
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  385  
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  386  	return irq_linear_revmap(qe_ic->irqhost, irq);
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  387  }
9865853851313e arch/powerpc/sysdev/qe_lib/qe_ic.c Li Yang     2006-10-03  388  

:::::: The code at line 384 was first introduced by commit
:::::: 9865853851313e0d94a4acde42d6f9d8070bb376 [POWERPC] Add QUICC Engine (QE) infrastructure

:::::: TO: Li Yang [off-list ref]
:::::: CC: Paul Mackerras [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation