Re: [PATCH v2 23/23] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

Hi Rasmus,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.4-rc5 next-20191028]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rasmus-Villemoes/QUICC-Engine-support-on-ARM/20191028-202537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d6d5df1db6e9d7f8f76d2911707f7d5877251b02
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11:0,
                    from include/linux/delay.h:22,
                    from drivers/net//wan/fsl_ucc_hdlc.c:7:
   drivers/net//wan/fsl_ucc_hdlc.c: In function 'uhdlc_init':

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^

quoted

drivers/net//wan/fsl_ucc_hdlc.c:198:6: note: in expansion of macro 'IS_ERR_VALUE'

     if (IS_ERR_VALUE(priv->ucc_pram_offset)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/net//wan/fsl_ucc_hdlc.c:236:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(riptr)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/net//wan/fsl_ucc_hdlc.c:243:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(tiptr)) {
         ^~~~~~~~~~~~
--
   In file included from include/linux/kernel.h:11:0,
                    from drivers/soc//fsl/qe/ucc_fast.c:11:
   drivers/soc//fsl/qe/ucc_fast.c: In function 'ucc_fast_init':

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^

quoted

drivers/soc//fsl/qe/ucc_fast.c:267:6: note: in expansion of macro 'IS_ERR_VALUE'

     if (IS_ERR_VALUE(uccf->ucc_fast_tx_virtual_fifo_base_offset)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/soc//fsl/qe/ucc_fast.c:280:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(uccf->ucc_fast_rx_virtual_fifo_base_offset)) {
         ^~~~~~~~~~~~
--
   In file included from include/linux/kernel.h:11:0,
                    from include/linux/delay.h:22,
                    from drivers/net/wan/fsl_ucc_hdlc.c:7:
   drivers/net/wan/fsl_ucc_hdlc.c: In function 'uhdlc_init':

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/net/wan/fsl_ucc_hdlc.c:198:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(priv->ucc_pram_offset)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/net/wan/fsl_ucc_hdlc.c:236:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(riptr)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/net/wan/fsl_ucc_hdlc.c:243:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(tiptr)) {
         ^~~~~~~~~~~~
--
   In file included from include/linux/kernel.h:11:0,
                    from drivers/soc/fsl/qe/ucc_fast.c:11:
   drivers/soc/fsl/qe/ucc_fast.c: In function 'ucc_fast_init':

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/soc/fsl/qe/ucc_fast.c:267:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(uccf->ucc_fast_tx_virtual_fifo_base_offset)) {
         ^~~~~~~~~~~~

quoted

include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
                                                    ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   drivers/soc/fsl/qe/ucc_fast.c:280:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(uccf->ucc_fast_rx_virtual_fifo_base_offset)) {
         ^~~~~~~~~~~~

vim +22 include/linux/err.h

ebba5f9fcb8823 Randy Dunlap   2006-09-27  21  
aa00edc1287a69 Linus Torvalds 2016-05-27 @22  #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
07ab67c8d0d7c1 Linus Torvalds 2005-05-19  23  

:::::: The code at line 22 was first introduced by commit
:::::: aa00edc1287a693eadc7bc67a3d73555d969b35d make IS_ERR_VALUE() complain about non-pointer-sized arguments

:::::: TO: Linus Torvalds [off-list ref]
:::::: CC: Linus Torvalds [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation