Re: [PATCH 4/7] soc: fsl: qe: replace spin_event_timeout by readx_poll_timeout_atomic
From: Christoph Hellwig <hch@infradead.org>
Date: 2019-10-18 16:08:57
Also in:
linux-arm-kernel, lkml
On Fri, Oct 18, 2019 at 02:52:31PM +0200, Rasmus Villemoes wrote:
/* wait for the QE_CR_FLG to clear */ - ret = spin_event_timeout((ioread32be(&qe_immr->cp.cecr) & QE_CR_FLG) == 0, - 100, 0); - /* On timeout (e.g. failure), the expression will be false (ret == 0), - otherwise it will be true (ret == 1). */ + ret = readx_poll_timeout_atomic(ioread32be, &qe_immr->cp.cecr, val, (val & QE_CR_FLG) == 0,
This creates an overly long line. Btw, given how few users of spin_event_timeout we have it might be good idea to just kill it entirely.