Re: [PATCH v3 9/9] powerpc/traps: Add line prefix in show_instructions()

Christophe LEROY [off-list ref] writes:

Le 31/07/2018 =C3=A0 16:50, Murilo Opsfelder Araujo a =C3=A9crit=C2=A0:

quoted

Remove "Instruction dump:" line by adding a prefix to display current->c=

omm

quoted

and current->pid, along with the instructions dump.
=20
The prefix can serve as a glue that links the instructions dump to its
originator, allowing messages to be interleaved in the logs.
=20
Before this patch, a page fault looked like:
=20
   pandafault[10524]: segfault (11) at 100007d0 nip 1000061c lr 7fffbd29=

5100 code 2 in pandafault[10000000+10000]

quoted

   Instruction dump:
   4bfffeec 4bfffee8 3c401002 38427f00 fbe1fff8 f821ffc1 7c3f0b78 3d22ff=

fe

quoted

   392988d0 f93f0020 e93f0020 39400048 <99490000> 39200000 7d234b78 383f=

0040

quoted

=20
After this patch, it looks like:
=20
   pandafault[10850]: segfault (11) at 100007d0 nip 1000061c lr 7fff9f3e=

5100 code 2 in pandafault[10000000+10000]

quoted

   pandafault[10850]: code: 4bfffeec 4bfffee8 3c401002 38427f00 fbe1fff8=

 f821ffc1 7c3f0b78 3d22fffe

quoted

   pandafault[10850]: code: 392988d0 f93f0020 e93f0020 39400048 <9949000=

0> 39200000 7d234b78 383f0040

quoted

=20
Signed-off-by: Murilo Opsfelder Araujo <redacted>

Does the script scripts/decode_stacktrace.sh also works with this format=

=20

change ?

Did it work before? I've never used it.

Would be great if it did work though.

cheers