Re: RFC on writel and writel_relaxed
From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-03-29 16:29:35
Also in:
linux-rdma, netdev
On Thu, Mar 29, 2018 at 3:56 PM, Sinan Kaya [off-list ref] wrote:
On 3/28/2018 11:55 AM, David Miller wrote:quoted
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Thu, 29 Mar 2018 02:13:16 +1100quoted
Let's fix all archs, it's way easier than fixing all drivers. Half of the archs are unused or dead anyway.Agreed.I pinged most of the maintainers yesterday. Which arches do we care about these days? I have not been paying attention any other architecture besides arm64. arch status detail ------ ------------- ------------------------------------ alpha question sent
I'm guessing alpha has problems
extern inline u32 readl(const volatile void __iomem *addr)
{
u32 ret = __raw_readl(addr);
mb();
return ret;
}
extern inline void writel(u32 b, volatile void __iomem *addr)
{
__raw_writel(b, addr);
mb();
}
There is a barrier in writel /after/ the acess but not before.
arc question sent ysato@users.sourceforge.jp will fix it. arm no issues arm64 no issues blackfin question sent about to be removed c6x question sent
no PCI, so it might not matter that much -- all drivers are platform specific in the end.
cris question sent frv
cris and frv are getting removed
h8300 question sent
no PCI
hexagon question sent
no PCI
ia64 no issues confirmed by Tony Luck m32r
removed
m68k question sent
metag
removed
microblaze question sent mips question sent
I'm guessing that some mips platforms have problems, but others don't.
mn10300 question sent
removed
nios2 question sent
no PCI
openrisc no issues shorne@gmail.com says should no issues parisc no issues grantgrundler@gmail.com says most probably no problem but still looking powerpc no issues riscv question sent
riscv should be fine
s390 question sent
Pretty sure this is also fine
score question sent
removed
sh question sent sparc question sent
tile question sent
removed
unicore32 question sent
Note the maintainer's new email address in linux-next.
x86 no issues
xtensa question sent
removed.
Arnd