Thread (76 messages) 76 messages, 4 authors, 2015-10-12

Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline

From: Joakim Tjernlund <hidden>
Date: 2015-09-22 20:07:56
Also in: lkml

quoted
And generally the one proposing uglification-for-optimization should pr=
ovide=20
quoted
the evidence. :-)
=20
When it comes to gcc, past history is my evidence until proven otherwise =
:)
Maybe I will check again ...
OK then:
static inline void mb(void)
{
       __asm__ __volatile__ ("sync" : : : "memory");
}

static inline void dcbf(void *addr)
{
       __asm__ __volatile__ ("dcbf 0, %0" : : "r"(addr) : "memory");
}
#define L1_CACHE_SHIFT 5
#define L1_CACHE_BYTES  (1 << L1_CACHE_SHIFT)
void flush_dcache_range(unsigned long start, unsigned long stop)
{
       void *addr =3D (void *)(start & ~(L1_CACHE_BYTES - 1));
       unsigned int size =3D stop - (unsigned long)addr + (L1_CACHE_BYTES -=
 1);
       unsigned int i;

       for (i =3D 0; i < size >> L1_CACHE_SHIFT; i++, addr +=3D L1_CACHE_BY=
TES)
               dcbf(addr);
       if (i)
               mb();   /* sync */
}

gives:
flush_dcache_range:
	stwu %r1,-16(%r1)
	rlwinm %r3,%r3,0,0,26
	addi %r4,%r4,31
	subf %r9,%r3,%r4
	srwi. %r10,%r9,5
	beq %cr0,.L1
	mtctr %r10
	.p2align 4,,15
.L4:
#APP
 # 8 "gccloop.c" 1
	dcbf 0, %r3
 # 0 "" 2
#NO_APP
	addi %r3,%r3,32
	bdnz .L4
#APP
 # 3 "gccloop.c" 1
	sync
 # 0 "" 2
#NO_APP
.L1:
	addi %r1,%r1,16
	blr

good enough :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help