Re: [PATCH v3 3/3] sched: BUG when stack end location is over written

On Fri, 2014-09-12 at 12:58 +0200, Mike Galbraith wrote:

On Fri, 2014-09-12 at 10:44 +0100, Aaron Tomlin wrote: 

quoted

On Fri, Sep 12, 2014 at 02:06:57PM +1000, Michael Ellerman wrote:

quoted

On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:

quoted

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a285900..2a8280a 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug

@@ -824,6 +824,18 @@ config SCHEDSTATS
 	  application, you can say N to avoid the very slight overhead
 	  this adds.
 
+config SCHED_STACK_END_CHECK
+	bool "Detect stack corruption on calls to schedule()"
+	depends on DEBUG_KERNEL
+	default y

Did you really mean default y?

Doing so means it will be turned on more or less everywhere, which defeats the
purpose of having a config option in the first place.

Only if Kconfig CONFIG_DEBUG_KERNEL is enabled in the first place.

Which is likely enabled just about everywhere on the planet.

Yes, including all distros I'm aware of.

cheers