Re: [PATCH v2 1/3] init/main.c: Give init_task a canary

From: Chuck Ebbert <hidden>
Date: 2014-09-11 12:23:52
Also in: lkml
Reply to: Aaron Tomlin, 2014-09-10

On Wed, 10 Sep 2014 14:29:33 +0100
Aaron Tomlin [off-list ref] wrote:

On Wed, Sep 10, 2014 at 02:26:54AM -0500, Chuck Ebbert wrote:

quoted

And has this been tested on parisc and metag, which use STACK_GROWSUP ?
I can't see how end_of_stack() as it's defined now could work on those archs.

AFAIU, dup_task_struct() has always done this explicitly.
I see no reason why init_task requires special attention.

I guess what I'm saying is, I can't see how the stack canary could have ever
detected any problems on parisc and metag. How did you test your patches on x86?
Maybe someone could run tests on those other archs.

Aaron Tomlin · 2014-09-04
[PATCH 1/2] sched: Add helper for task stack page overrun checking · Aaron Tomlin · 2014-09-04
Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking · Oleg Nesterov · 2014-09-04
Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking · Aaron Tomlin · 2014-09-04
Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking · Peter Zijlstra · 2014-09-04
[PATCH 2/2] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-04
Re: [PATCH 2/2] sched: BUG when stack end location is over written · Peter Zijlstra · 2014-09-04
Re: [PATCH 2/2] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-04
[PATCH v2 0/3] sched: Always check the integrity of the canary · Aaron Tomlin · 2014-09-08
[PATCH 1/3] init/main.c: Give init_task a canary · Aaron Tomlin · 2014-09-08
[PATCH 2/3] sched: Add helper for task stack page overrun checking · Aaron Tomlin · 2014-09-08
[PATCH 3/3] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-08
[PATCH v2 0/3] sched: Always check the integrity of the canary · Aaron Tomlin · 2014-09-09
[PATCH v2 2/3] sched: Add helper for task stack page overrun checking · Aaron Tomlin · 2014-09-09
[PATCH v2 3/3] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-09
[PATCH v2 1/3] init/main.c: Give init_task a canary · Aaron Tomlin · 2014-09-09
Re: [PATCH v2 1/3] init/main.c: Give init_task a canary · Chuck Ebbert · 2014-09-10
Re: [PATCH v2 1/3] init/main.c: Give init_task a canary · Aaron Tomlin · 2014-09-10
Re: [PATCH v2 1/3] init/main.c: Give init_task a canary · Chuck Ebbert · 2014-09-11
Re: [PATCH v2 1/3] init/main.c: Give init_task a canary · Aaron Tomlin · 2014-09-11
[PATCH v3 0/3] sched: Always check the integrity of the canary · Aaron Tomlin · 2014-09-11
[PATCH v3 2/3] sched: Add helper for task stack page overrun checking · Aaron Tomlin · 2014-09-11
[PATCH v3 3/3] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-11
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Michael Ellerman · 2014-09-12
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-12
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Mike Galbraith · 2014-09-12
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Michael Ellerman · 2014-09-15
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Michael Ellerman · 2014-09-12
Re: [PATCH v3 3/3] sched: BUG when stack end location is over written · Aaron Tomlin · 2014-09-12
[PATCH v3 1/3] init/main.c: Give init_task a canary · Aaron Tomlin · 2014-09-11
Re: [PATCH v3 1/3] init/main.c: Give init_task a canary · Michael Ellerman · 2014-09-12
Re: [PATCH v3 0/3] sched: Always check the integrity of the canary · Peter Zijlstra · 2014-09-11
Re: [PATCH v3 0/3] sched: Always check the integrity of the canary · Aaron Tomlin · 2014-09-11
RE: [PATCH v3 0/3] sched: Always check the integrity of the canary · David Laight · 2014-09-11
Re: [PATCH v3 0/3] sched: Always check the integrity of the canary · Chuck Ebbert · 2014-09-11
RE: [PATCH v3 0/3] sched: Always check the integrity of the canary · David Laight · 2014-09-12
Re: [PATCH v3 0/3] sched: Always check the integrity of the canary · Aaron Tomlin · 2014-09-11
View all 37 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help