On 07/28/2013 09:20:11 PM, Liu Po-B43644 wrote:

=20
=20

quoted

 -----Original Message-----
 From: Wood Scott-B07421
 Sent: Saturday, July 27, 2013 5:59 AM
 To: Liu Po-B43644
 Cc: linuxppc-dev@ozlabs.org; galak@kernel.crashing.org; Fleming =20

Andy-

quoted

 AFLEMING; Hu Mingkai-B21284; Liu Po-B43644
 Subject: Re: [PATCH v2 3/3] powerpc/85xx: Add C293PCIE board =20

support

quoted

 On 07/25/2013 09:41:19 PM, Po Liu wrote:
 > +		partition@1900000 {
 > +			/* 7MB for User Area */
 > +			reg =3D <0x01900000 0x00700000>;
 > +			label =3D "NAND User area";
 > +		};
 > +
 > +		partition@2000000 {
 > +			/* 96MB for Root File System */
 > +			reg =3D <0x02000000 0x06000000>;
 > +			label =3D "NAND Root File System";
 > +		};
 > +
 > +		partition@8000000 {
 > +			/* 3968MB for Others */
 > +			reg =3D <0x08000000 0xF8000000>;
 > +			label =3D "NAND Others";
 > +		};

 Again, what is the difference between "user area" and "others"?  =20

I'm not

quoted

 even sure why it needs to be separate from "root file system", but =20

at

quoted

 least the root filesystem should be larger given the size of the =20

overall

quoted

 flash.

Do you mean just merge up four partition into one "RFS"? Or merge up =20
four partition into "RFS" and "User area" is better?

If you don't have a reason for separating them, then probably yes, =20
merge them all into one.  If you do keep RFS and "user area" separate, =20
then "user area" should be the larger of the two, but the RFS should be =20
more than just 96 MiB.

quoted

 > +			partition@580000 {
 > +				/* 10.5MB for Compressed RFS =20

Image */

quoted

 > +				reg =3D <0x00580000 0x00a80000>;
 > +				label =3D "SPI Flash Compressed =20

RFSImage";

quoted

 > +			};

 Space before "Image".  Why specifiy that it's compressed, versus =20

some

quoted

 other filesystem type?

Remove all the "compressed" comments when express the RFS partition?

Yes.

-Scott=