-----Original Message-----
 From: Wood Scott-B07421
 Sent: Saturday, July 27, 2013 5:59 AM
 To: Liu Po-B43644
 Cc: linuxppc-dev@ozlabs.org; galak@kernel.crashing.org; Fleming Andy-
 AFLEMING; Hu Mingkai-B21284; Liu Po-B43644
 Subject: Re: [PATCH v2 3/3] powerpc/85xx: Add C293PCIE board support
=20
 On 07/25/2013 09:41:19 PM, Po Liu wrote:
 > +		partition@1900000 {
 > +			/* 7MB for User Area */
 > +			reg =3D <0x01900000 0x00700000>;
 > +			label =3D "NAND User area";
 > +		};
 > +
 > +		partition@2000000 {
 > +			/* 96MB for Root File System */
 > +			reg =3D <0x02000000 0x06000000>;
 > +			label =3D "NAND Root File System";
 > +		};
 > +
 > +		partition@8000000 {
 > +			/* 3968MB for Others */
 > +			reg =3D <0x08000000 0xF8000000>;
 > +			label =3D "NAND Others";
 > +		};
=20
 Again, what is the difference between "user area" and "others"?  I'm not
 even sure why it needs to be separate from "root file system", but at
 least the root filesystem should be larger given the size of the overall
 flash.

Do you mean just merge up four partition into one "RFS"? Or merge up four p=
artition into "RFS" and "User area" is better?

=20
 Also please use lowercase for hex.
=20
 > +	};
 > +
 > +	cpld@2,0 {
 > +		#address-cells =3D <1>;
 > +		#size-cells =3D <1>;
 > +		compatible =3D "fsl,c293pcie-cpld";
 > +		reg =3D <0x2 0x0 0x20>;
 > +	};
=20
 Remove #address-cells/#size-cells
=20
 > +			partition@580000 {
 > +				/* 10.5MB for Compressed RFS Image */
 > +				reg =3D <0x00580000 0x00a80000>;
 > +				label =3D "SPI Flash Compressed RFSImage";
 > +			};
=20
 Space before "Image".  Why specifiy that it's compressed, versus some
 other filesystem type?
=20

Remove all the "compressed" comments when express the RFS partition?

 -Scott