Thread (25 messages) 25 messages, 5 authors, 2009-12-14

Re: spi_mpc8xxx.c: chip select polarity problem

From: Anton Vorontsov <hidden>
Date: 2009-11-26 18:42:00
Also in: linux-spi

On Thu, Nov 26, 2009 at 11:16:34AM -0700, Grant Likely wrote:
[...]
The spi-cs-high property is defined in
Documentation/powerpc/dts-bindings/spi-bus.txt, but it definitely was
a mistake
Yup.
Currently the spi-cs-high property is parsed in the
of_register_spi_devices() function, but the CS polarity needs to be
known before registering devices.  It needs to be factored out into
another utility function callable by spi bus drivers so that it can
get polarity data at probe time.
Untill we have this, Torsten's patch is a real improvement, and
works for non-broken hw/fw.

So I think it should be applied.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help