Thread (101 messages) 101 messages, 19 authors, 2008-06-12

Re: MMIO and gcc re-ordering issue

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-05-27 03:39:46
Also in: linux-arch, lkml

On Mon, 2008-05-26 at 19:28 -0700, David Miller wrote:
quoted
But heh, it's you who was telling me that it would be a bad
engineering
quoted
decision and we had to make everybody look like x86 & fully
ordered :-)
quoted
I decided to agree back then and stuck all those nasty heavy
barriers
quoted
in the powerpc variants of readl/writel/...
I still believe this.

It's just another complicated thing for driver authors to get wrong.
The other side of the coin is of course the cost.

The only thing I am absolutely sure of is that we should make a
decision fast, document it, and just stick to it.
Yes. As it is today, tg3 for example is potentially broken on all archs
with newer gcc unless we either add "memory" clobber to readl/writel or
stick some wmb's in there (just a random driver I picked).

So Linus, what is your take on that matter ?

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help