Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote:

On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote:

quoted

On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote:

quoted

On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote:

quoted

 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC
+	depends on EMBEDDED || ARCH_PPC

It needs to be || PPC, not || ARCH_PPC.

Wrong. It needs to be EMBEDDED || ARCH_RPC || PPC.

Why is it dependent on anything other than platform bus support and ATA?

There's no way to specify dependency on platform bus as a config option,
that's likely what EMBEDDED was meant to do. Some platforms have platform
bus in spite of being !EMBEDDED, arch/arm/configs/rpc_defconfig seems
to be among those. PPC too.


-Olof