Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote:

On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote:

quoted

On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote:

quoted

 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC
+	depends on EMBEDDED || ARCH_PPC

It needs to be || PPC, not || ARCH_PPC.

Wrong. It needs to be EMBEDDED || ARCH_RPC || PPC.

ARCH_RPC is not a typo, it's an ARM platform. Please grep first :-)

I'm sorry, but seeing ARCH_RPC and not having an arch/rpc made me
suspect it being a typo. It surprises me that the ARM guys chose such
a generic prefix as ARCH_ for their specific platforms.  (powerpc uses
PPC_<platform>).

Anyway, thanks for catching it.


-Olof