RE: [patch][5/5] powerpc V2: Add the general support for EmbeddedFloating-Point instructions
From: Zhu Ebony-r57400 <hidden>
Date: 2007-03-08 07:12:09
=20
-----Original Message----- From: linuxppc-dev-bounces+ebony.zhu=3Dfreescale.com@ozlabs.org=20 [mailto:linuxppc-dev-bounces+ebony.zhu=3Dfreescale.com@ozlabs.or g] On Behalf Of Kumar Gala Sent: Friday, February 23, 2007 2:23 AM To: Sergei Shtylyov Cc: linuxppc-dev@ozlabs.org; paulus@samba.org Subject: Re: [patch][5/5] powerpc V2: Add the general support=20 for EmbeddedFloating-Point instructions =20 =20 On Feb 22, 2007, at 10:56 AM, Sergei Shtylyov wrote: =20quoted
Hello. Segher Boessenkool wrote:quoted
quoted
quoted
quoted
arch/powerpc/sysdev/sigfpe_handler.c | 361 ++++++++++++++++++++++++++++++++++quoted
quoted
quoted
I'm sorry, but is sysdev/ really fitting place for this file? Shouldn't it be under kernel/ or math-emu/ instead?quoted
quoted
Also, the name doesn't look fittingto me, since we're not=20 handling *SIGFPE* here (which is for userland), we're handling SPE=20 exceptions.quoted
arch/powerpc/math-emu/spe/<whatever>.c seems like a good place?Yeah, certainly more like it. :-)quoted
Segher=20 Agreed, this shouldn't have been in sysdev, didn't notice that :) =20 We should probably rename this as well, since its not just=20 handling the sigfpe part, but the actual fixup/emulation. =20 - k
Hi All, Base on your suggestion, how about move sigfpe_handler.c to arch/powerpc/math-emu/spe/spe_handler.c? Or do you have any other suggestions on file name? B.R. Ebony