On Feb 22, 2007, at 10:56 AM, Sergei Shtylyov wrote:

Hello.

Segher Boessenkool wrote:

quoted

quoted

quoted

quoted

 arch/powerpc/sysdev/sigfpe_handler.c |  361
++++++++++++++++++++++++++++++++++

quoted

quoted

quoted

   I'm sorry, but is sysdev/ really fitting place for this file?
Shouldn't it be under kernel/ or math-emu/ instead?

quoted

quoted

    Also, the name doesn't look fittingto me, since we're not  
handling
*SIGFPE* here (which is for userland), we're handling SPE  
exceptions.

quoted

arch/powerpc/math-emu/spe/<whatever>.c seems like a good
place?

    Yeah, certainly more like it. :-)

quoted

Segher

Agreed, this shouldn't have been in sysdev, didn't notice that :)

We should probably rename this as well, since its not just handling  
the sigfpe part, but the actual fixup/emulation.

- k