RE: [patch][5/5] powerpc V2: Add the general support for Embedded Floating-Point instructions
From: Zhu Ebony-r57400 <hidden>
Date: 2007-02-09 05:15:27
=20
quoted
quoted
quoted
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/=20kernel/head_fsl_booke.S index 66877bd..0d05db0 100644--- a/arch/powerpc/kernel/head_fsl_booke.S +++ b/arch/powerpc/kernel/head_fsl_booke.S@@ -705,7 +705,7 @@ #else #endif /* CONFIG_SPE */ /* SPE Floating Point Round */ - EXCEPTION(0x2050, SPEFloatingPointRound, unknown_exception,EXC_XFER_EE) + EXCEPTION(0x2050, SPEFloatingPointRound, SPEFloatingPointException_Round, EXC_XFER_EE) /* Performance Monitor */ EXCEPTION(0x2060, PerformanceMonitor,=20 performance_monitor_exception, EXC_XFER_STD) @@ -840,6 +840,8 @@=20 load_up_spe: oris r5,r5,MSR_SPE@h mtmsr r5 /* enable use of SPE now */ isync + li r5,(SPEFSCR_FINVE | SPEFSCR_FDBZE | SPEFSCR_FUNFE | SPEFSCR_FOVFE) + mtspr SPRN_SPEFSCR,r5We should do this via INIT_THREAD, is there a reason that=20you want to=20quoted
quoted
set these always?I just thought it's the first time that an SPE instruction is=20 encountered, so I enable the exceptions here.=20 Lets do this via INIT_THREAD instead, its cleaner. (just=20 remember to add the proper ifdef protection for SPE_IEEE
Talking about INIT_THREAD, I'm wondering where is the best place to enble the exceptions? Please advice! And also, I will put all of your other suggestions into next patches. Thank you! B.R. Ebony