Re: [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI

On Mon, 5 Mar 2007 10:06:06 +0100 (CET) Geert Uytterhoeven [off-list ref] wrote:

On Mon, 5 Mar 2007, Benjamin Herrenschmidt wrote:

quoted

On Sun, 2007-03-04 at 19:59 +0100, Arnd Bergmann wrote:

quoted

On Sunday 04 March 2007, Benjamin Herrenschmidt wrote:

quoted

On Sun, 2007-03-04 at 15:07 +0100, Arnd Bergmann wrote:

quoted

On Sunday 04 March 2007 07:04:44 Stephen Rothwell wrote:

quoted

 config PCI
        bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \
-               || PPC_MPC52xx || (EMBEDDED && PPC_ISERIES) || MPC7448HPC2 || PPC_PS3
+               || PPC_MPC52xx || (EMBEDDED &&  (PPC_PSERIES || PPC_ISERIES)) \
+               || MPC7448HPC2 || PPC_PS3

I dislike the giant conditional though.

How about changing it to

config PCI_ENABLE
	bool

Call it PCI_CAPABLE rather...

And I guess PS3 can be removed from the list, as we don't use fake PCI anymore.

The list above is really the list of platforms on which the person compiling the kernel get a choice about having PCI support.  Whether PCI is enabled or not by default is decided by the (unquoted) following lines:

        default y if !40x && !CPM2 && !8xx && !APUS && !PPC_83xx \
                && !PPC_85xx && !PPC_86xx
        default PCI_PERMEDIA if !4xx && !CPM2 && !8xx && APUS
        default PCI_QSPAN if !4xx && !CPM2 && 8xx

Which is a whole different can of worms :-)

So if PS3 doesn't use PCI at all then it should be removed from the above list and
	default n if PPC_PS3
should be added ..

Let me try to do a patch on top of the current set.
--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/