Re: [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI

On Mon, 5 Mar 2007, Benjamin Herrenschmidt wrote:

On Sun, 2007-03-04 at 19:59 +0100, Arnd Bergmann wrote:

quoted

On Sunday 04 March 2007, Benjamin Herrenschmidt wrote:

quoted

On Sun, 2007-03-04 at 15:07 +0100, Arnd Bergmann wrote:

quoted

On Sunday 04 March 2007 07:04:44 Stephen Rothwell wrote:

quoted

 config PCI
        bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \ 
-               || PPC_MPC52xx || (EMBEDDED && PPC_ISERIES) || MPC7448HPC2 || PPC_PS3 
+               || PPC_MPC52xx || (EMBEDDED &&  (PPC_PSERIES || PPC_ISERIES)) \ 
+               || MPC7448HPC2 || PPC_PS3 

I dislike the giant conditional though.

How about changing it to

config PCI_ENABLE
	bool

Call it PCI_CAPABLE rather...

And I guess PS3 can be removed from the list, as we don't use fake PCI anymore.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium