Re: [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI

On Sunday 04 March 2007, Benjamin Herrenschmidt wrote:

On Sun, 2007-03-04 at 15:07 +0100, Arnd Bergmann wrote:

quoted

On Sunday 04 March 2007 07:04:44 Stephen Rothwell wrote:

quoted

=A0config PCI
=A0 =A0 =A0 =A0 bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_=

85xx || PPC_86xx \=20

quoted

quoted

- =A0 =A0 =A0 =A0 =A0 =A0 =A0 || PPC_MPC52xx || (EMBEDDED && PPC_ISER=

IES) || MPC7448HPC2 || PPC_PS3=20

quoted

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 || PPC_MPC52xx || (EMBEDDED && =A0(PPC_=

PSERIES || PPC_ISERIES)) \=20

quoted

quoted

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 || MPC7448HPC2 || PPC_PS3=20

=20

I dislike the giant conditional though.

How about changing it to

config PCI_ENABLE
	bool

config PCI
	bool "PCI support" if PCI_ENABLE

config PPC_PSERIES
	select PCI_ENABLE
	select PCI if !EMBEDDED

config PPC_PS3
	select PCI_ENABLE

config PPC_PMAC
	select PCI

	Arnd <><